refactor(main): adopt electron-menubar v10 for window/tray/system handling#2880
Merged
Conversation
github-actions
Bot
added
dependency
Member
|
These comments are more for
|
Member
|
What do you think about a more universal package name such as We could also contribute a Renovate replacement rule which would help all the other consumers of max-mapper/menubar migration from the unmaintained v9 to v10 |
Member
Author
|
|
Member
|
Oh really, I had searched npmjs before but couldn't see any conflicts |
# Conflicts: # package.json # pnpm-lock.yaml
# Conflicts: # pnpm-workspace.yaml
|
setchy
changed the title
electron-menubar v10 for window/tray/system handling
setchy
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menubardependency for our hard forkedelectron-menubar(v10) and lean on its built-in features.hideOnClose,escapeToHide,recenterOnTray), tray context-menu wiring/SNI refresh, and the global keyboard shortcut to the menubar instance.lifecycle/window.ts,handlers/tray.ts, andhandlers/system.ts, simplifying tests accordingly.